Skip to content

[Reputation Oracle] refactor: use module ref for factory method - #3390

Merged
dnechay merged 1 commit into
developfrom
dnechay/module-ref
Jun 13, 2025
Merged

[Reputation Oracle] refactor: use module ref for factory method#3390
dnechay merged 1 commit into
developfrom
dnechay/module-ref

Conversation

@dnechay

@dnechay dnechay commented Jun 12, 2025

Copy link
Copy Markdown
Collaborator

Issue tracking

Freestyle

Context behind the change

Changed the way of how we retrieve instances of escrow processors. Before we directly injected them to main class, but in order to simplify that and improve readability use moduleRef container from Nest directly now.

How has this been tested?

  • unit tests

Release plan

Just merge

Potential risks; What to monitor; Rollback plan

Don't see any

@dnechay dnechay self-assigned this Jun 12, 2025
@vercel

vercel Bot commented Jun 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Jun 12, 2025 9:41am
faucet-server ⬜️ Ignored (Inspect) Jun 12, 2025 9:41am
human-app ⬜️ Skipped (Inspect) Jun 12, 2025 9:41am
human-dashboard-frontend ⬜️ Skipped (Inspect) Jun 12, 2025 9:41am
staking-dashboard ⬜️ Skipped (Inspect) Jun 12, 2025 9:41am

@dnechay
dnechay requested review from Dzeranov and flopez7 June 12, 2025 09:41

@flopez7 flopez7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnechay
dnechay merged commit 606bec1 into develop Jun 13, 2025
@dnechay
dnechay deleted the dnechay/module-ref branch June 13, 2025 09:09
@dnechay dnechay mentioned this pull request Jun 13, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants